-
Notifications
You must be signed in to change notification settings - Fork 8
Fix for few FPs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for few FPs #15
Conversation
|
Thanks you very much! Yes, we will increase the version number. |
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
I can increase it from my side. It's a simple |
No, I'd rather have a separate PR for that. |
|
There's something wrong with the test setup. I need to investigate that before we can merge. That reminds me: if you're up for it it would be nice to have your FP's covered by tests. |
|
Guys, i would not change the version numbers yet. None of the plugins was officially released yet and there is no need for a version change. Let's wait until CRS 4.0 and then we will release all plugins under current versions (and also we will do a downloadable release here on github). |
|
@Xhoenix Can you add yourself into the |
|
@Xhoenix rule ID |
|
Merged, thanks to everyone! |
1 similar comment
|
Merged, thanks to everyone! |
As promised in my last PR, here are 10 more FPs. There are a few more FPs, but I forgot to label them as PL 1 and they got mixed with my PL 2 FPs. @theseion if you find a typo or mistake, kindly make changes where necessary. Thank you.
Also, we need to update the plugin version to 1.0.1, as done with WordPress plugin.