Skip to content

Conversation

@Xhoenix
Copy link
Member

@Xhoenix Xhoenix commented Mar 28, 2023

As promised in my last PR, here are 10 more FPs. There are a few more FPs, but I forgot to label them as PL 1 and they got mixed with my PL 2 FPs. @theseion if you find a typo or mistake, kindly make changes where necessary. Thank you.

Also, we need to update the plugin version to 1.0.1, as done with WordPress plugin.

@theseion
Copy link
Contributor

Thanks you very much! Yes, we will increase the version number.

Xhoenix and others added 3 commits March 29, 2023 01:25
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
@Xhoenix
Copy link
Member Author

Xhoenix commented Mar 28, 2023

Thanks you very much! Yes, we will increase the version number.

I can increase it from my side. It's a simple sed command.

@theseion
Copy link
Contributor

I can increase it from my side. It's a simple sed command.

No, I'd rather have a separate PR for that.

@theseion
Copy link
Contributor

There's something wrong with the test setup. I need to investigate that before we can merge.

That reminds me: if you're up for it it would be nice to have your FP's covered by tests.

@azurit
Copy link
Member

azurit commented Mar 29, 2023

Guys, i would not change the version numbers yet. None of the plugins was officially released yet and there is no need for a version change. Let's wait until CRS 4.0 and then we will release all plugins under current versions (and also we will do a downloadable release here on github).

@azurit
Copy link
Member

azurit commented Mar 29, 2023

@Xhoenix Can you add yourself into the CONTRIBUTORS.md? Thanks.

@theseion
Copy link
Contributor

@Xhoenix rule ID 9508602 is a duplicate, that's why the tests fail.

@theseion
Copy link
Contributor

Thanks @Xhoenix. @azurit, I'll leave merging to you.

@azurit azurit merged commit 14baff9 into coreruleset:main Mar 30, 2023
@azurit
Copy link
Member

azurit commented Mar 30, 2023

Merged, thanks to everyone!

1 similar comment
@azurit
Copy link
Member

azurit commented Mar 30, 2023

Merged, thanks to everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants