Skip to content
This repository was archived by the owner on Sep 22, 2020. It is now read-only.

file: tiny: output trace log before call writeToBlock #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

file: tiny: output trace log before call writeToBlock #422

wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Dec 7, 2016

No description provided.

@lpabon
Copy link

lpabon commented Dec 9, 2016

Why is this change needed?

@nak3
Copy link
Contributor Author

nak3 commented Dec 10, 2016

There are several reasons.

For example, writeToBlock() in file_cache.go#L92 has a panic() call. If this panic() is called before the trace log, we cannot see the blkIndex which caused the issue.
Read in file.go#L274-L277 implements this correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nak3 @lpabon