compose: If repos is unset, use global ones #5118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c46951f.
Part of https://gitlab.com/fedora/bootc/tracker/-/issues/32 This will simplify the hacks we have in Containerfile there. As part of this intended UX, the repositories come from the global set. Signed-off-by: Colin Walters <walters@verbum.org>
travier
approved these changes
Oct 4, 2024
jlebon
approved these changes
Oct 4, 2024
|
I think a lot of things in the existing test suite would start to blow up if we leaked the host repos...but you're right. Testing this explicitly is clearly doable, just need to figure out where. Hmm...I dunno. I may actually instead do a different spike on "productizing" https://gitlab.com/fedora/bootc/base-images-experimental/-/blob/main/build/dnf-installroot |
|
Moving this back to draft, it's not in a blocking path right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://gitlab.com/fedora/bootc/tracker/-/issues/32
This will simplify the hacks we have in Containerfile there.
As part of this intended UX, the repositories come from the
global set.
Signed-off-by: Colin Walters walters@verbum.org