Deprecate cliwrap #5088
Merged
Deprecate cliwrap #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking at handling kernel overrides: - coreos#4726 - https://gitlab.com/fedora/bootc/tracker/-/issues/22 And I think the cliwrap thing turned out to be the wrong approach for this. There's consensus now it was the wrong approach, so deprecate it. Signed-off-by: Colin Walters <walters@verbum.org>
ipanova
approved these changes
Sep 13, 2024
| # Wrapping other CLI entrypoints | ||
| # DEPRECATED: Wrapping other CLI entrypoints | ||
|
|
||
| **This functionality is now deprecated and slated for removal**. |
There was a problem hiding this comment.
If it is known in what upcoming breaking-changes version it's going to be removed it's better to specify it.
There was a problem hiding this comment.
Totally agree, but I have no idea when we'll be able to do that unfortunately right now.
Given that we documented enabling cliwrap for kernel overrides today, it may be far into the future. Ideally though we'll have the kernel replacement replacement ready by the time this one actually ships in a release.
jlebon
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at handling kernel overrides:
And I think the cliwrap thing turned out to be the wrong approach for this.
There's consensus now it was the wrong approach, so deprecate it.