rpm-ostree ignores CTRL-C while downloading rpm-md or rpms #897
Comments
|
Blog I did on this topic a while ago: https://blog.verbum.org/2013/12/03/cancelling-computation-gcancellable-or-sigint-versus-threads-versus-exceptions/ The problem isn't that librepo takes over Ultimately I think what we need to do is make the transaction a subprocess, and not a thread. Then cancel = |
While we have cancellation issues¹, let's help the user understand that we heard them the first time. ¹ <coreos#897>
|
See also #897 |
This is a quick band-aid to improve Ctrl-C handling in this area: coreos#897 At least this way we'll exit earlier rather than waiting until all the repos are downloaded (and imported into libsolv, which is itself slow).
|
I had this issue running the Fedora 28 Atomic Workstation install and I’m not concerned that the system took a few minutes to respond, but now when I try and run my rpm-ostree upgrade again it’s failing with an error about a partial package at about the same point I canceled. |
|
@FotomicWS, could you try cleaning out the cache using |
|
@jlebon Thanks for the note. I did try |
|
Could you file a separate issue? Make sure to also paste the exact error message you're receiving as well. Thanks! |
|
Tried it one more time to make sure I get that error message correct and it completed without error. I hadn't run the `rpm-ostree cleanup -m' previously, and I didn't reboot after that, so maybe rebooting was necessary. Been stuck on that error for days, '[18] Transferred a partial file'. Between that and trying to get pulse network going...reminds me of the supercross race in Seattle last weekend, LInux mudding. I see it downgraded Firefox, so maybe that was part of the issue. I'll reboot and file a separate issue if it's not completely resolved. Thanks again for the help. :) |
|
Looks good. I also ran that software update applet a few times after discovering that today too. It said it had updates, but it never installed, just prompted for reboot. But maybe that changed something. I don’t know why I hit Ctrl-C. Must have been tired, but I should have suspended and came back to it. |
I've been wanting to do this for a long time, but was too intimidated at the thought of doing it in C. One big thing to do here is to move the transaction heavy lifting into a subprocess. That would be a lot of work; just forking off the dnf fetching would help solve coreos#897 Another case where I want do to this is to drop privileges for the curl bits we do now for `rpm-ostree install http://`. There's not a lot here yet, just me experimenting with Servo's "ipc-channel".
I've been wanting to do this for a long time, but was too intimidated at the thought of doing it in C. One big thing to do here is to move the transaction heavy lifting into a subprocess. That would be a lot of work; just forking off the dnf fetching would help solve coreos#897 Another case where I want do to this is to drop privileges for the curl bits we do now for `rpm-ostree install http://`. There's not a lot here yet, just me experimenting with Servo's "ipc-channel".
Basically I am in the middle of a transaction that is taking longer than expected and I try to CTRL-C and I see where it says
cancelling transactionbut then keeps going printing status updates to the screen about download progress.After some time it finally finishes with
error: Operation was cancelled.I've been told this is because librepo takes over SIGINT and causes this behavior.
The text was updated successfully, but these errors were encountered: