Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpm-ostree support for modules #1435

Closed
dustymabe opened this issue Jun 29, 2018 · 12 comments
Closed

Add rpm-ostree support for modules #1435

dustymabe opened this issue Jun 29, 2018 · 12 comments
Labels
difficulty/hard hard complexity/difficutly issue kind/enhancement

Comments

@dustymabe
Copy link
Member

See devel list thread. It looks like cri-o might start going modular. Can rpm-ostree support this (I know we inherit most functionality from dnf libraries, but there are probably some things to consider).

I saw #744 but this question wasn't really addressed there I don't think.
@cgwalters cgwalters changed the title can rpm-ostree compose tree support installing modules? Add rpm-ostree compose tree support for modules Jun 29, 2018
@cgwalters
Copy link
Member

I haven't tried, offhand my understanding is we'd only support the default streams, although I'm not even sure of that.

Enhancements here block on rebasing libdnf but that's only the start...some of what libdnf does today is wrong for rpm-ostree (like the sqlite database in /var etc.)

@cgwalters cgwalters mentioned this issue Jul 23, 2018
Open
@cgwalters cgwalters mentioned this issue Sep 10, 2018
Closed
@dustymabe dustymabe added the difficulty/hard hard complexity/difficutly issue label Nov 1, 2018
@dustymabe
Copy link
Member Author

Marking this as hard. Let me know if that needs to be adjusted.

jcpowermac pushed a commit to jcpowermac/workstation-ostree-config that referenced this issue Mar 7, 2019
@cgwalters
post: Disable modular repositories
ce5cc7a 
See coreos/rpm-ostree#1435
and coreos/rpm-ostree#1542 (comment)
@jlebon
Copy link
Member

jlebon commented Mar 19, 2019

The libdnf rebase is done now!

Note there is a hack in fedora-coreos-config to disable modular repos we'll want to drop once rpm-ostree becomes module aware.

@jlebon
Copy link
Member

jlebon commented Mar 20, 2019

Related: #1404 (comment).

I haven't looked into this yet, so not sure how much work it'll actually be. At the very least though, if we don't want to block the next release on this, we should see if we can just tell libdnf to be module-unaware as it was before the rebase.

@jlebon jlebon mentioned this issue Mar 20, 2019
Closed
jlebon added a commit to jlebon/rpm-ostree that referenced this issue Mar 22, 2019
@jlebon
core: Don't exclude modular packages
424c01b 
For now, we don't natively support modules. But we still want to be able
to install modular packages if the repos are enabled, but libdnf
automatically filters them out. So for now, let's tell libdnf that we do
want to be able to see them.

Related: coreos#1435
@jlebon jlebon mentioned this issue Mar 22, 2019
Closed
@jlebon
Copy link
Member

jlebon commented Mar 22, 2019

I was looking at this today and how dnf module works. The first thing that jumps out is that almost all the module APIs are C++, and dnf uses the SWIG bindings. So... that complicates things.

Anyway, short term fix in #1797 at least so we can get a release out soon.

rh-atomic-bot pushed a commit that referenced this issue Mar 22, 2019
@jlebon @rh-atomic-bot
core: Don't exclude modular packages
28c3a4c 
For now, we don't natively support modules. But we still want to be able
to install modular packages if the repos are enabled, but libdnf
automatically filters them out. So for now, let's tell libdnf that we do
want to be able to see them.

Related: #1435

Closes: #1797
Approved by: cgwalters
@jlebon
Copy link
Member

jlebon commented Apr 5, 2019

Was chatting with @imcleod about this. One thing we need to look into here is that libdnf should be overriding packages from the default stream if a modular repo is enabled, even if it's older than the same RPM from a non-modular repo. It doesn't seem like that's what we're seeing today.

jcpowermac pushed a commit to jcpowermac/workstation-ostree-config that referenced this issue Apr 8, 2019
@cgwalters
post: Disable modular repositories
1ff6019 
See coreos/rpm-ostree#1435
and coreos/rpm-ostree#1542 (comment)
@jlebon jlebon mentioned this issue Jul 5, 2019
Closed
@cgwalters cgwalters changed the title Add rpm-ostree compose tree support for modules Add rpm-ostree support for modules Oct 23, 2019
@cgwalters
Copy link
Member

Current state of this is best summarized in
#1864 (comment)

Basically, modules are implemented by filtering the repodata which we don't do, so rpm-ostree will tend to just pick the highest NEVRA. In some cases this will work fine, in others it won't.

jlebon added a commit to jlebon/rpm-ostree that referenced this issue Jan 8, 2020
@jlebon
core: Mark all repos as "modular hotfixes"
06c02b7 
This is a follow-up hack to coreos#1797 to force libdnf to let us use modular
packages as if they were regular packages until we actually support
modules correctly (coreos#1435).

A repo marked as a modular hotfix means that libdnf doesn't try to
filter out modular RPMs from the repo as it usually does.

Resolves: https://pagure.io/releng/failed-composes/issue/717
@jlebon jlebon mentioned this issue Jan 8, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Jan 8, 2020

rpm-software-management/libdnf#874

@jlebon jlebon mentioned this issue Jan 8, 2020
Closed
jlebon added a commit to jlebon/rpm-ostree that referenced this issue Jan 8, 2020
@jlebon
core: Mark all repos as "modular hotfixes"
e97b4e9 
This is a follow-up hack to coreos#1797 to force libdnf to let us use modular
packages as if they were regular packages until we actually support
modules correctly (coreos#1435).

A repo marked as a modular hotfix means that libdnf doesn't try to
filter out modular RPMs from the repo as it usually does.

Resolves: https://pagure.io/releng/failed-composes/issue/717
openshift-merge-robot pushed a commit that referenced this issue Jan 9, 2020
@jlebon @openshift-merge-robot
core: Mark all repos as "modular hotfixes"
2966afe 
This is a follow-up hack to #1797 to force libdnf to let us use modular
packages as if they were regular packages until we actually support
modules correctly (#1435).

A repo marked as a modular hotfix means that libdnf doesn't try to
filter out modular RPMs from the repo as it usually does.

Resolves: https://pagure.io/releng/failed-composes/issue/717
@jlebon jlebon mentioned this issue Jun 8, 2020
Closed
@rfairley rfairley mentioned this issue Jun 11, 2020
Merged
@miabbott miabbott mentioned this issue Jun 19, 2020
Closed
@LorbusChris
Copy link
Collaborator

It seems libdnf now has a C interface for modules: rpm-software-management/libdnf#874 (comment)

@LorbusChris LorbusChris mentioned this issue Mar 12, 2021
Open
@haircommander
Copy link

out of curiosity, does there exist a timeline that this may be implemented in @dustymabe @cgwalters ?

@jlebon jlebon mentioned this issue Apr 16, 2021
Closed
@jlebon
Copy link
Member

jlebon commented Apr 16, 2021

Blocked on rpm-software-management/libdnf#874 (comment)

@jlebon
Copy link
Member

jlebon commented Aug 3, 2021

This is fixed now by #2760! 🎉

@jlebon jlebon closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/hard hard complexity/difficutly issue kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cgwalters @dustymabe @haircommander @jlebon @LorbusChris