-
Notifications
You must be signed in to change notification settings - Fork 12
rust/checklist: update fedora packaging section #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Packit submits the PR after a new version is released upstream, so we can remove those steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Although do we have packit on all the repos ? |
Good point, looks like we haven't yet integrated Packit in https://github.com/coreos/afterburn. |
@jcapiitao would you want to set up packit on afterburn? we can use it soon for the new release we are going to do there. |
yes, I'll work on that |
@dustymabe just proposed a PR to do so coreos/afterburn#1189 |
Something I don't remember is how does Packit does backports to branches. We wanted to keep the fast-forward nature of those updates. |
You mean the backport of |
Ideally we use fast forward pushes for all branches. Looks like https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/77 made the branches diverge. |
I know that there is a functionality in packit to do it now as we requested it, but I don't remember how it works. |
Right, I had to cherry-pick the Packit's patch on F42, as I could not rebase. I'll reconcile the branches.
I like the idea of Packit submitting a PR backporting rawhide commit to stable branches, as this will automatically trigger a scratch build, whereas we might forget to do so when done manually. Let's implement it. |
I amended my afterburn PR to include the configuration telling Packit to backport to stable branches c.f https://github.com/coreos/afterburn/pull/1189/files#diff-2b4300f6d69654fd71c0cdd329b5a5f13fa8fe7eb709c76276bdfd3ea1dde578R21-R23 |
Packit submits the PR after a new version is released upstream, so we can remove those steps.