Skip to content

rust/checklist: update fedora packaging section #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcapiitao
Copy link

Packit submits the PR after a new version is released upstream, so we can remove those steps.

Packit submits the PR after a new version is released upstream,
so we can remove those steps.
Copy link

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jbtrystram
Copy link

Although do we have packit on all the repos ?

@jcapiitao
Copy link
Author

jcapiitao commented Apr 18, 2025

Although do we have packit on all the repos ?

Good point, looks like we haven't yet integrated Packit in https://github.com/coreos/afterburn.
Let's put on hold this PR then

@dustymabe
Copy link
Member

@jcapiitao would you want to set up packit on afterburn? we can use it soon for the new release we are going to do there.

@jcapiitao
Copy link
Author

@jcapiitao would you want to set up packit on afterburn? we can use it soon for the new release we are going to do there.

yes, I'll work on that

@jcapiitao
Copy link
Author

@dustymabe just proposed a PR to do so coreos/afterburn#1189

@travier
Copy link
Member

travier commented Apr 28, 2025

Something I don't remember is how does Packit does backports to branches. We wanted to keep the fast-forward nature of those updates.

@jcapiitao
Copy link
Author

Something I don't remember is how does Packit does backports to branches. We wanted to keep the fast-forward nature of those updates.

You mean the backport of rawhide patches to stable branches ? If so, I think it does not, at least according to the coreos-installer distgit repo the rebase/cherry-pick is done manually before the fedpkg push && fedpkg build.

@travier
Copy link
Member

travier commented Apr 28, 2025

Ideally we use fast forward pushes for all branches. Looks like https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/77 made the branches diverge.

@travier
Copy link
Member

travier commented Apr 28, 2025

I know that there is a functionality in packit to do it now as we requested it, but I don't remember how it works.

@jcapiitao
Copy link
Author

Ideally we use fast forward pushes for all branches. Looks like https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/77 made the branches diverge.

Right, I had to cherry-pick the Packit's patch on F42, as I could not rebase. I'll reconcile the branches.

I know that there is a functionality in packit to do it now as we requested it, but I don't remember how it works.

* https://packit.dev/docs/configuration/downstream/pull_from_upstream#optional-parameters

* https://packit.dev/docs/configuration/upstream/propose_downstream#optional-parameters

I like the idea of Packit submitting a PR backporting rawhide commit to stable branches, as this will automatically trigger a scratch build, whereas we might forget to do so when done manually. Let's implement it.

@jcapiitao
Copy link
Author

I amended my afterburn PR to include the configuration telling Packit to backport to stable branches c.f https://github.com/coreos/afterburn/pull/1189/files#diff-2b4300f6d69654fd71c0cdd329b5a5f13fa8fe7eb709c76276bdfd3ea1dde578R21-R23
Also, I double checked that all stable branches in Fedora dist-git are synced, it's all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants