capnslog: set SYSLOG_IDENTIFIER for journal #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,8 @@ func (j *journaldFormatter) Format(pkg string, l LogLevel, _ int, entries ...int | |||
| } | |||
| msg := fmt.Sprint(entries...) | |||
| tags := map[string]string{ | |||
| "PACKAGE": pkg, | |||
| "PACKAGE": pkg, | |||
| "SYSLOG_IDENTIFIER": os.Args[0], | |||
Fixes coreos#40. I think it's reasonable to just set this by default rather than needing to expose it to users. References: http://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html#SYSLOG_FACILITY= http://linux.die.net/man/3/program_invocation_short_name
|
updayted |
|
LGTM |
jonboulle
added a commit
that referenced
this pull request
Oct 24, 2015
capnslog: set SYSLOG_IDENTIFIER for journal
|
might it be better to use https://github.com/kardianos/osext for this? |
|
Maybe it would be better to use /proc/self/exe, but I'd rather not import On Sat, Oct 24, 2015 at 3:44 PM, Nick Owens notifications@github.com
|
jonboulle
added a commit
to jonboulle/etcd
that referenced
this pull request
Nov 6, 2015
Update to catch coreos/pkg#43 which should fix SYSLOG_IDENTIFIER getting set when etcd is logging to the journal.
jonboulle
added a commit
to jonboulle/etcd
that referenced
this pull request
Nov 9, 2015
Update to catch coreos/pkg#43 which should fix SYSLOG_IDENTIFIER getting set when etcd is logging to the journal.
yichengq
pushed a commit
to yichengq/etcd
that referenced
this pull request
Nov 19, 2015
Update to catch coreos/pkg#43 which should fix SYSLOG_IDENTIFIER getting set when etcd is logging to the journal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40. I think it's reasonable to just set this by default rather than
needing to expose it to users.
References:
http://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html#SYSLOG_FACILITY=
http://linux.die.net/man/3/program_invocation_short_name