This repository was archived by the owner on Jun 23, 2022. It is now read-only.
kube-client-agent: Allow empty --ipaddrs flag. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abhinavdahiya
approved these changes
Apr 16, 2018
cmd/kube-client-agent/request.go
Outdated
| return fmt.Errorf("invalid ipaddress: %s", addr) | ||
| var ips []net.IP | ||
|
|
||
| if requestOpts.ipAddresses != "" { |
There was a problem hiding this comment.
Could you add a comment here stating that we allow empty ipAddress flag
For peer cert request, we don't need ip address flag since we always use dns name to contact the peer.
yifan-gu
force-pushed
the
allow_empty_ipaddrs
branch
from
7e94935 to
1a1bdf0
Compare
|
@rithujohn191 Addressed the comments. |
rithujohn191
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For peer cert request, we don't need ip address flag since we always
use dns name to contact the peer.