Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news for 0.27.0 #610

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Add news for 0.27.0 #610

merged 1 commit into from
Aug 9, 2018

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Aug 9, 2018

Shout out to @arithx for helping drafting these notes.

@coreosbot
Copy link
Contributor

Can one of the admins verify this patch?

@arithx
Copy link
Contributor

arithx commented Aug 9, 2018

Typical format for the commit title is: news: add news for v{version}

@jlebon jlebon force-pushed the pr/new-release branch 2 times, most recently from 3a1a1e5 to f51fc7c Compare August 9, 2018 19:41
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally.

Here come the nits!

NEWS Outdated
Features:

- Ignition is now built as a Position Independent Executable (PIE)
- Blackbox tests now run against all versions (within the same major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all spec versions might be a bit clearer.

NEWS Outdated
- Blackbox tests now run against all versions (within the same major
version) after their minimum version
- Status reporting for Packet
- Files are now relabeled for SELinux after boot (requires setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That setting will be obscure to most Ignition users. Maybe (if enabled at compile time)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reworked that whole sentence since it felt misleading to say "Files are now relabeled! ... but you have to enable this flag".

NEWS Outdated

- Directories that are specified in appended configs are now always created
second (allowing the appended config to control the permissions)
- Fix missing `chdir()` after `chroot()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies security vulnerability to anyone who knows chroot, but that doesn't seem to actually be the case here. Any way to fix that? Add chdir() after chroot() to silence static checkers?

We could omit the note entirely, but that doesn't feel quite right.

NEWS Outdated
Bug Fixes:

- Directories that are specified in appended configs are now always created
second (allowing the appended config to control the permissions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directories specified in both base and appended configs are always created with the permissions specified in the appended config?

NEWS Outdated

- Ignition is now built as a Position Independent Executable (PIE)
- Blackbox tests now run against all versions (within the same major
version) after their minimum version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/after/greater than/

NEWS Outdated
- Ignition is now built as a Position Independent Executable (PIE)
- Blackbox tests now run against all versions (within the same major
version) after their minimum version
- Status reporting for Packet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report Ignition status to cloud when running on Packet?

NEWS Outdated

Features:

- Ignition is now built as a Position Independent Executable (PIE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bullets are not properly indented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullets were correctly indented, but the headings were not. Fixed!

@jlebon jlebon force-pushed the pr/new-release branch 2 times, most recently from e736d3b to d95ea6d Compare August 9, 2018 20:18
NEWS Outdated
- Ignition is now built as a Position Independent Executable (PIE)
- Blackbox tests now run against all spec versions (within the same major
version) greater than their minimum version
- Report Ignition status to cloud when running on Packet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tense change, Fix it if you like, I don't think it's super important either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked it. ⬇️

@jlebon
Copy link
Member Author

jlebon commented Aug 9, 2018

(good to merge)

@ajeddeloh ajeddeloh merged commit cc7ebe0 into coreos:master Aug 9, 2018
@dustymabe
Copy link
Member

Nice work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants