Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news for 0.26.0, 0.25.1, 0.24.1 #561

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Conversation

ajeddeloh
Copy link
Contributor

Add news for branched releases
Add news for 0.26.0

@arithx
Copy link
Contributor

arithx commented Jun 11, 2018

s,0.26.0,v0.26.0,g

NEWS Outdated

Features:

- Expand partitioning support to support filesystem reuse like semantics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than comparing the feature to a different feature, can we just say what it does?

NEWS Outdated
Bug Fixes:

- Fix an issue in timeout logic causing http(s) requests to sometimes fail
- Do not log non-critial errors with CRITIAL log level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical, CRITICAL

@ajeddeloh
Copy link
Contributor Author

Fixed typos, added v, redescribed partitioning changes

NEWS Outdated

Features:

- Expand partitioning support to support partition matching, specifying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: support to support sounds weird

NEWS Outdated

- Expand partitioning support to support partition matching, specifying
partitions should not exist, and creating existing partitions
- Fail blackbox tests when Ignition encounters critical errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: encounters critical-level logs might be a tad clearer

NEWS Outdated
Features:

- Expand partitioning to support partition matching, specifying
partitions should not exist, and creating existing partitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifying that a partition should not exist

Could also drop Expand partitioning to.

creating existing partitions reads oddly; creating partitions that may already exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, was supposed to be "recreating existing partitions"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants