config: allow arbitrary custom clevis pin #2145
Conversation
In order to support new clevis pin, either they need to be added each time in the hardcoded list of pins or ignition can allow any name for the pin. This is required in order to enable the clevis trustee pin used for confidential clusters. Signed-off-by: Alice Frosi <afrosi@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the configuration validation to allow for arbitrary custom Clevis pin names. The change is motivated by the need to support new pins, such as the 'trustee' pin, without having to update a hardcoded list. The implementation correctly removes the switch statement that enforced a whitelist of pin names in config/v3_6_experimental/types/clevis.go. The corresponding unit test in config/v3_6_experimental/types/clevis_test.go is also updated to reflect that a previously unknown pin name is now considered valid. The changes are straightforward, correct, and align with the pull request's objective. I have no further comments.
|
This PR has been created upon the discussion in #2120 (comment) |
|
How do I fix the release notes? |
| }, | ||
| at: path.New("", "pin"), | ||
| out: errors.ErrUnknownClevisPin, | ||
| out: nil, |
There was a problem hiding this comment.
Can we add a negative test as well please?
There was a problem hiding this comment.
There are already existing tests covering when the name is empty, so I'm not sure what else we should check. This PR is relaxing the name checking to arbitrarily non-empty string
@alicefr you need to write a simple release notes on ignition/docs/release-notes.md about your change. 😸 |
|
Hey, @alicefr! Thanks for working on this 🫂 |
Signed-off-by: Alice Frosi <afrosi@redhat.com>
3 participants
In order to support new clevis pin, either they need to be added each time in the hardcoded list of pins or ignition can allow any name for the pin. This is required in order to enable the clevis trustee pin used for confidential clusters.