Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync repo templates ⚙ #1952

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Oct 11, 2024

@prestist
Copy link
Collaborator

Once coreos/repo-templates#249 lands I will do some shuffling

As of 1.22.7 golang's go tool fix no longer self populates.
you can see the changes here:
golang/go@676d610#diff-a4f750f77a9e274ac048407886b3e210cdde1543878d681a6fa96b9d2ec49c23R69

fixes: coreos#1950
With the newer version of the linter some code has been flagged.
Add code changes where possible and ignores when needed.
@prestist prestist added the skip-notes This PR does not need release notes label Oct 11, 2024
Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@prestist prestist merged commit 9871e7c into coreos:main Oct 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants