Add azure blob support #1923
Add azure blob support #1923
Conversation
|
Still needs to be tested, working through that atm. |
prestist
force-pushed
the
add-azureblob-support
branch
from
0b8dda6 to
86ec426
Compare
prestist
force-pushed
the
add-azureblob-support
branch
3 times, most recently
from
c94adc9 to
c14396b
Compare
|
I have tested this and it does work! yay; Alright; outstanding things; Obviously need to rebase and fix conflicts ✅ Need to add documentation, and I started here on this documentation; was thinking about examples.md but after thinking about it I dont think that makes any sense, there is no sig change and it would work from the point of remote-ign files. Was thinking about breaking out the parse logic for url into a func just for unit testing but wdyt? |
use azure sdk to authorize, initiate and fetch ignition config file from azure blob storage. fixes: https://issues.redhat.com/browse/COS-2859
prestist
force-pushed
the
add-azureblob-support
branch
from
c14396b to
c99df9d
Compare
| return fmt.Errorf("failed to create azblob client: %w", err) | ||
| } | ||
|
|
||
| // Download the blob with retry logic |
There was a problem hiding this comment.
Hum, shouldn't the retry happen as part of the wider retry loop in Ignition?
There was a problem hiding this comment.
Ah, yes that makes sense; I did not consider that at all. Will drop the retry logic.
There was a problem hiding this comment.
I agree with you that would be helpful to break this into a separate function and write a unit test. It would also be nice to include other scenarios, like testing the Azure Blob Storage client creation and its errors. But not sure if this is the scope of the URL test file.
Separated commits because of the extreme of vendoring.