provider/cloudstack: use nm to get metadata address #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Ignition tries to use networkd DHCP leases to get the metadata service address in CloudStack provider. As Fedora CoreOS switched to NetworkManager, CloudStack metadata cannot be found anymore. With this commit, Ignition uses several methods in order to find the address of the CloudStack Virtual Router (which serves the metadata service): 1. A DNS request on "data-server"; 2. The DHCP option "dhcp_server_identifier" as returned by NetworkManager (queried using DBus) 3. The current process (networkd DHCP leases) 4. The default gateway (as defined in /proc/net/route) Cf. coreos/fedora-coreos-tracker#716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Ignition tries to use networkd DHCP leases to get the metadata service address in CloudStack provider.
As Fedora CoreOS switched to NetworkManager, CloudStack metadata cannot be found anymore (Afterburn has the same problem: coreos/afterburn#146)
With this PR, Ignition uses several methods in order to find the address of the CloudStack Virtual Router (which serves the
metadata service):
I kept method 3 only for compatibility reasons, but I can remove it (it does not work with Fedora CoreOS 34). The order of methods is inspired by cloud-init.
Cf. coreos/fedora-coreos-tracker#716