-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go module support #307
Conversation
We touched this topic in the past with @arithx, and we are a bit cautious. Relevant sharp edges:
|
Maybe we can switch to go mod in next release? Use |
I'd like to do a couple of first-hand experiments before that, in particular wrt. subpackages and module-version, so likely not targeting this at the next release. |
Also relevant here: go-systemd consumes I'll check and arrange to get the latter moved to |
Additionally, it is my current understanding that we have to rewrite all our internal imports to be in the form |
Yes, we need to update all files while upgrading major version. Golang may add |
Hey, any idea how to move forward here? The latest version of godbus/dbus is now using a v5 import suffix which makes it hard to use go-systemd with projects using go modules. |
@saschagrunert thanks for pinging back. I think we can more or less stick to the plan highlighted so far.
I don't have any of this on my current radar as I'm unfortunately already fully-booked on other topics, but I'll gladly review any PR and try to quickly cut releases when ready. If you have a pressing timeline on this, feel free to start PRing. |
What a coincidence; I'm currently struggling with exactly this issue, too. I don't feel proficient enough in Go to roll a PR, so the only thing left for me is to wait. Sigh... |
92eac10
to
ee1f571
Compare
Would it be fine if we drop the build for go 1.10/11? Because the v5 imports won't work with that. |
282bb4a
to
a219758
Compare
PTAL |
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
a219758
to
b5f71cb
Compare
Is there some kind of workaround for people trying to use this package in a module environment, or will we just have to wait around for this to get merged? |
I right now stick to an older version. @lucab do you think we can move forward here? |
Ah, I didn't realize this was re-pushed after my last review. LGTM now, I'll merge. |
Wow, that was quick! Thanks |
This PR adds a
go.mod
andgo.sum
to the project which contains the latest dependencies. It would be awesome if we could tag a release according to semver after this PR got merged, WDYT? 😇