Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add checklist for rebasing to a new version of Fedora #806

Merged
merged 1 commit into from
Apr 29, 2021
Merged

templates: add checklist for rebasing to a new version of Fedora #806

merged 1 commit into from
Apr 29, 2021

Conversation

bgilbert
Copy link
Contributor

@lucab lucab merged commit 3a56d5b into coreos:master Apr 29, 2021
lucab pushed a commit to coreos/fedora-coreos-config that referenced this pull request Apr 29, 2021
@bgilbert bgilbert deleted the rebase branch April 29, 2021 16:37
@bgilbert
Copy link
Contributor Author

@dustymabe @jlebon PTAL and verify that I got the sequencing right.

@dustymabe
Copy link
Member

@bgilbert mostly LGTM. I've got some small things to add in a follow up. Should we just link to this template from the fedora-coreos-config README? It could get confusing if there is more than one place for things to live.

@bgilbert
Copy link
Contributor Author

@dustymabe I put the link in the fedora-coreos-config README (coreos/fedora-coreos-config#987) because I couldn't think of a better place to document it. I'm open to ideas.

@dustymabe
Copy link
Member

@dustymabe I put the link in the fedora-coreos-config README (coreos/fedora-coreos-config#987) because I couldn't think of a better place to document it. I'm open to ideas.

Oh man.. You did exactly what I was requesting.. I just didn't see you had already done it! Ignore me :)

## Ship rebased `next`

- [ ] Ship `next`
- [ ] Set a new update barrier for N-2 on `next`. In the barrier entry set a link to [the docs](https://docs.fedoraproject.org/en-US/fedora-coreos/update-barrier-signing-keys/). See [discussion](https://github.com/coreos/fedora-coreos-tracker/issues/480#issuecomment-631724629).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this doesn't actually address the intended purpose: #749 (comment).

We'll need to revisit that eventually, but right now there's actually no use in adding these barriers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@bgilbert bgilbert Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or alternatively #810, mid-air collision 💥)

HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants