Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional documentation around users and groups #148

Merged
merged 1 commit into from
Aug 25, 2020
Merged

add additional documentation around users and groups #148

merged 1 commit into from
Aug 25, 2020

Conversation

miabbott
Copy link
Member

@miabbott miabbott commented Aug 7, 2020

Closes #23

@miabbott miabbott force-pushed the configuring_users branch 3 times, most recently from 06e5609 to 8061fb8 Compare August 8, 2020 14:01
jlebon
jlebon reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for writing this!

modules/ROOT/pages/configuring-users.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/configuring-users.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/configuring-users.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/configuring-users.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/configuring-users.adoc Outdated Show resolved Hide resolved
bgilbert
bgilbert reviewed Aug 10, 2020
View reviewed changes
modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
travier
travier approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor double spacing but otherwise LGTM. I wonder if we could run checks like that on the docs in CI.

modules/ROOT/pages/authentication.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/authentication.adoc Outdated Show resolved Hide resolved
@miabbott
Copy link
Member Author

Two minor double spacing but otherwise LGTM. I wonder if we could run checks like that on the docs in CI.

Old habits die hard. :)

@bgilbert bgilbert mentioned this pull request Aug 12, 2020
Open
2 tasks
@jlebon jlebon merged commit d5c4cc7 into coreos:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert left review comments

@jlebon jlebon jlebon approved these changes

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user-guides: document user setup
4 participants
@miabbott @bgilbert @jlebon @travier