manifest: add kexec-tools for kdump #708
Conversation
This was discussed in: coreos/fedora-coreos-tracker#622
| @@ -252,6 +255,9 @@ | |||
| "elfutils-libs": { | |||
| "evra": "0.181-1.fc32.x86_64" | |||
| }, | |||
| "ethtool": { | |||
There was a problem hiding this comment.
The only reason this appears to be needed is to handle bonding and teaming: https://src.fedoraproject.org/rpms/kexec-tools/blob/master/f/dracut-module-setup.sh#_189, which is unfortunate. I think we have code which also deals with those, so maybe we can submit a patch to drop that dep.
| @@ -1026,12 +1035,18 @@ | |||
| "slirp4netns": { | |||
| "evra": "1.1.4-1.fc32.x86_64" | |||
| }, | |||
| "snappy": { | |||
There was a problem hiding this comment.
For compressing dump with snappy. Dynamically linked.
| "socat": { | ||
| "evra": "1.7.3.4-2.fc32.x86_64" | ||
| }, | ||
| "sqlite-libs": { | ||
| "evra": "3.33.0-2.fc32.x86_64" | ||
| }, | ||
| "squashfs-tools": { |
There was a problem hiding this comment.
It uses dracut's built-in support for putting files in a squashfs.
There was a problem hiding this comment.
Right but why does it do that? What's the squashfs image? I am not finding docs for this; the main hit I see so far is:
grep -ri squash /usr/lib/dracut/modules.d/99kdumpbase/
/usr/lib/dracut/modules.d/99kdumpbase/module-setup.sh: is_squash_available() {
/usr/lib/dracut/modules.d/99kdumpbase/module-setup.sh: for kmodule in squashfs overlay loop; do
/usr/lib/dracut/modules.d/99kdumpbase/module-setup.sh: if is_squash_available && ! is_fadump_capable; then
/usr/lib/dracut/modules.d/99kdumpbase/module-setup.sh: _dep="$_dep squash"
/usr/lib/dracut/modules.d/99kdumpbase/module-setup.sh: dwarning "Required modules to build a squashed kdump image is missing!"
but that doesn't help.
There was a problem hiding this comment.
I'll admit I only actually looked over the dracut code for this to get a sense of why it pulls it in. What I gathered is that it puts the meat of the initramfs files in a squashfs to save space.
OK, some dist-git sleuthing led me to https://src.fedoraproject.org/rpms/kexec-tools/c/9b6e3124477212b8321392b2f365beddd7881e22?branch=master and dracutdevs/dracut@095e1f3, which more or less confirms this. The squashfs is part of the initrd, and dracut mounts it early on and things carry on transparently.
From https://src.fedoraproject.org/rpms/kexec-tools/c/4a44eee472745f8dd43b18815851bd668b7497da?branch=master though, it clearly can work fine without it. So we could try to see if the maintainers are interested in making it a weak dep. I'm not sure if I'd block inclusion into RHCOS for this though.
There was a problem hiding this comment.
There was a problem hiding this comment.
And of course, there's the question of whether we actually want to opt out of those RAM savings. From dracutdevs/dracut@095e1f3, it seems like not a lot, though somewhat significant in proportion to the total amount of RAM to reserve. If that PR gets merged, we can ship without it as a first cut at least.
| @@ -228,6 +228,9 @@ | |||
| "dracut-network": { | |||
| "evra": "050-61.git20200529.fc32.x86_64" | |||
| }, | |||
| "dracut-squash": { | |||
There was a problem hiding this comment.
It uses dracut's built-in support for putting files in a squashfs.
|
https://src.fedoraproject.org/rpms/kexec-tools/pull-request/4 was merged now, so in the future |
|
Hello CoreOS team, I have reverted the commit "Make dracut-squash a weak dep" to make Although kexec-tools can work without dracut-squash, but it is essential Besides, kdump is evolving. Currently new features [3] of kdump to enhance Thanks! [1] https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/thread/MX7INNHDHXKS4JXARMSYYHVEV2HOFHID/ |
|
@liutgnu Thanks for following up here. IIUC, this will also solve /cc @kelvinfan001 |
|
On our end, we'll need to update the docs to instruct users to reserve less memory for the crash kernel ( |
|
Thanks for the updating. @jlebon @kelvinfan001 |
fedora-coreos-config: bump to c4ca6f6
This was discussed in:
coreos/fedora-coreos-tracker#622