Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: fedora-coreos-base: add back in podman-plugins, dnsmasq #693

Merged
merged 1 commit into from
Oct 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions manifest-lock.x86_64.json
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@
"diffutils": {
"evra": "3.7-4.fc32.x86_64"
},
"dnsmasq": {
"evra": "2.81-4.fc32.x86_64"
},
"dosfstools": {
"evra": "4.1-10.fc32.x86_64"
},
Expand Down Expand Up @@ -921,6 +924,9 @@
"podman": {
"evra": "2:2.1.1-7.fc32.x86_64"
},
"podman-plugins": {
"evra": "2:2.1.1-7.fc32.x86_64"
},
"policycoreutils": {
"evra": "3.0-2.fc32.x86_64"
},
Expand Down
11 changes: 11 additions & 0 deletions manifests/fedora-coreos-base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ postprocess:
EOF
fi

# Mask dnsmasq. We include dnsmasq for host services that use the dnsmasq
# binary but intentionally mask the systemd service so users can't easily
# use it as an external dns server. We prefer they use a container for that.
# https://github.com/coreos/fedora-coreos-tracker/issues/519
- |
#!/usr/bin/env bash
systemctl mask dnsmasq.service

packages:
# Security
- selinux-policy-targeted
Expand All @@ -98,6 +106,9 @@ packages:
# Containers
- podman skopeo runc systemd-container catatonit
- fuse-overlayfs slirp4netns
# name resolution for podman containers
# https://github.com/coreos/fedora-coreos-tracker/issues/519
- podman-plugins dnsmasq
# Remote IPC for podman
- libvarlink-util
# Networking
Expand Down
7 changes: 7 additions & 0 deletions tests/kola/misc-ro
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,10 @@ if [ -e /dev/zram0 ]; then
fatal "zram0 swap device set up on default install"
fi
ok no zram swap by default

# make sure dnsmasq is masked
# https://github.com/coreos/fedora-coreos-tracker/issues/519#issuecomment-705140528
if [ $(systemctl is-enabled dnsmasq.service) != 'masked' ]; then
fatal "dnsmasq.service systemd unit should be masked"
fi
ok "dnsmasq.service systemd unit is masked"