Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override #464

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

rfairley
Copy link
Contributor

@rfairley rfairley commented Jun 9, 2020

Opening to test an existing non-modular fedora-coreos-pinger-0.0.4-3.fc32 build sourced from Koji, when modular repos are disabled.

Not building with modular content will fix: coreos/fedora-coreos-tracker#525

@rfairley
Copy link
Contributor Author

rfairley commented Jun 9, 2020

@dustymabe
Copy link
Member

You can leave the modular repos in the .repo files. Just remove them from the manifest.

@rfairley rfairley changed the title [hold] Remove modular repos, add fedora-coreos-pinger-0.0.4-3.fc32 override [hold] Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override Jun 10, 2020
@rfairley
Copy link
Contributor Author

Build succeeded! https://jenkins-coreos-ci.apps.ci.centos.org/blue/organizations/jenkins/github-ci%2Fcoreos%2Ffedora-coreos-config/detail/PR-464/2/pipeline

This would work I'll try and sort out the rebuild in F32 and Bodhi update first. Asked in Fedora releng IRC about the f33 tag in https://koji.fedoraproject.org/koji/buildinfo?buildID=1452289, and the best thing would be rebuilding https://src.fedoraproject.org/rpms/rust-fedora-coreos-pinger/pull-request/2.

@zonggen
Copy link
Member

zonggen commented Jun 10, 2020

Thank you @rfairley for proceeding this 👍

Robert Fairley added 2 commits June 10, 2020 18:59
Add the recent non-modular fedora-coreos-pinger build to
overides, removing our dependency on modular content. Part
of fixing coreos/fedora-coreos-tracker#525.

Overriding is necessary as there is no Bodhi update yet.
The Bodhi update is pending a Fedora admin building with the
side tag to make the package available in F32. Permissions for
us to create the side tag are also pending, see:
https://pagure.io/releng/issue/9229. Once either of the two
pending above are completed, we'll be able to create and add
the Bodhi update here (see TODO in the manifest).
Remove modular repos from the list in this file, as we no longer
require sourcing modular content. Part of:
coreos/fedora-coreos-tracker#525
@rfairley rfairley changed the title [hold] Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override Jun 10, 2020
@rfairley
Copy link
Contributor Author

Good to merge on green CI

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 74c98c2 into coreos:testing-devel Jun 10, 2020
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
tests: Enable TPM test for all arches except s390x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package layering fails on f32 base with modular packages
3 participants