-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override #464
Don't use modular repos in manifest, add fedora-coreos-pinger-0.0.4-3.fc32 override #464
Conversation
503 on Koji https://jenkins-coreos-ci.apps.ci.centos.org/blue/organizations/jenkins/github-ci%2Fcoreos%2Ffedora-coreos-config/detail/PR-464/1/pipeline/ - will try this again later. |
You can leave the modular repos in the .repo files. Just remove them from the manifest. |
4dbfda5
to
b5c65d5
Compare
Build succeeded! https://jenkins-coreos-ci.apps.ci.centos.org/blue/organizations/jenkins/github-ci%2Fcoreos%2Ffedora-coreos-config/detail/PR-464/2/pipeline This would work I'll try and sort out the rebuild in F32 and Bodhi update first. Asked in Fedora releng IRC about the f33 tag in https://koji.fedoraproject.org/koji/buildinfo?buildID=1452289, and the best thing would be rebuilding https://src.fedoraproject.org/rpms/rust-fedora-coreos-pinger/pull-request/2. |
Thank you @rfairley for proceeding this 👍 |
Add the recent non-modular fedora-coreos-pinger build to overides, removing our dependency on modular content. Part of fixing coreos/fedora-coreos-tracker#525. Overriding is necessary as there is no Bodhi update yet. The Bodhi update is pending a Fedora admin building with the side tag to make the package available in F32. Permissions for us to create the side tag are also pending, see: https://pagure.io/releng/issue/9229. Once either of the two pending above are completed, we'll be able to create and add the Bodhi update here (see TODO in the manifest).
Remove modular repos from the list in this file, as we no longer require sourcing modular content. Part of: coreos/fedora-coreos-tracker#525
b5c65d5
to
65f48ae
Compare
Good to merge on green CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests: Enable TPM test for all arches except s390x
Opening to test an existing non-modular fedora-coreos-pinger-0.0.4-3.fc32 build sourced from Koji, when modular repos are disabled.
Not building with modular content will fix: coreos/fedora-coreos-tracker#525