Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp-test: update check to run instance with confidential type sev-snp #3157

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

HuijingHei
Copy link
Member

yasminvalim
yasminvalim previously approved these changes Sep 12, 2024
Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe
Copy link
Member

it feels weird to me that this test is named nvme-symlink but runs on confidential VMs. I'd never guess it from the name. Maybe confidential-vm-nvme-symlink would work better?

dustymabe
dustymabe previously approved these changes Sep 12, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuijingHei
Copy link
Member Author

it feels weird to me that this test is named nvme-symlink but runs on confidential VMs. I'd never guess it from the name. Maybe confidential-vm-nvme-symlink would work better?

Updated, thanks!

travier
travier previously approved these changes Sep 13, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

when this merges we'll need to cherry-pick it to testing so that our next stable build will have successful gcp tests.

@dustymabe dustymabe merged commit 0b797dd into coreos:testing-devel Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants