This repository was archived by the owner on Mar 28, 2020. It is now read-only.
k8sutil: Restarting pods in an etcd cluster with PVC is safe. #2097
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple fix that addresses Case C from https://github.com/coreos/etcd-operator/blob/master/doc/design/persistent_volumes_etcd_data.md It makes the etcd cluster with PVC able to recover from full k8s cluster outage. Inspired by coreos#1323 (comment) Fixes coreos#1323
Collaborator
|
Can one of the admins verify this patch? |
2 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
|
Any updates on this? Without this PVCs aren't really that effective. |
|
Shouldn't PV have |
laurelnaiad
added a commit
to laurelnaiad/etcd-operator
that referenced
this pull request
Jan 21, 2020
When PVC is used, make the pod auto recover in case of failure. Source: coreos#2097
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix that addresses Case C from
https://github.com/coreos/etcd-operator/blob/master/doc/design/persistent_volumes_etcd_data.md
It makes the etcd cluster with PVC able to recover from full k8s cluster
outage. Inspired by #1323 (comment)
Fixes #1323
Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow