Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not checking curl exit code #29

Closed
jlebon opened this issue May 13, 2019 · 4 comments · Fixed by #31
Closed

Not checking curl exit code #29

jlebon opened this issue May 13, 2019 · 4 comments · Fixed by #31

Comments

@jlebon
Copy link
Member

jlebon commented May 13, 2019 •
edited by arithx
Loading

Just noticed this while reading over the codebase. Should wait $curl_pid or something to make sure we error out if curl dies halfway.
@yuqi-zhang
Copy link
Contributor

Related, note since we're doing a curl -L only, https://github.com/coreos/coreos-installer/blob/master/coreos-installer#L435 will always have a RETCODE of 0

@arithx
Copy link
Contributor

arithx commented May 17, 2019

@jlebon are you okay with me opening up a different issue for integrity checking and scoping this down to checking the curl exit code only?

@jlebon
Copy link
Member Author

jlebon commented May 17, 2019

@arithx Yup, totally fine!

@arithx
Copy link
Contributor

arithx commented May 17, 2019

Opened up #30 for integrity checking

arithx added a commit to arithx/coreos-installer that referenced this issue May 17, 2019
@arithx
coreos-installer: add check for image download exit status
52f5f6d 
Adds an additional check for the exit status of the curl call that does
the image download.

Closes coreos#29
@arithx arithx mentioned this issue May 17, 2019
Merged
arithx added a commit to arithx/coreos-installer that referenced this issue May 17, 2019
@arithx
coreos-installer: add check for image download exit status
c4703a0 
Adds an additional check for the exit status of the curl call that does
the image download.

Closes coreos#29
glennswest referenced this issue in glennswest/coreos-installer Mar 31, 2020
@arithx
coreos-installer: add check for image download exit status
e979760 
Adds an additional check for the exit status of the curl call that does
the image download.

Closes #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

coreos-installer: add check for image download exit status arithx/coreos-installer
3 participants
@arithx @jlebon @yuqi-zhang