WIP: Add and enable cmd-buildext-azure command #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithx
reviewed
Jun 25, 2019
arithx
reviewed
Jun 25, 2019
|
Rebased to use #571 |
|
Only skimmed this, looks sane to me, but I have the same question on it that I had for GCP around user workflow - we don't need to necessarily solve it here. What is the state of this? The title says WIP, is that still true? Has this been tested? |
|
This is still WIP. @imcleod is working on top of this PR. |
|
This is obsoleted I believe, please reopen if that's not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to be the base for further
azurecommand work.Note: this section in the previous PR adds in making the images public and syncing. They were left out of this PR as it may make more sense for that to be done by a pipeline rather than for every build. However, if it should be done every time the code can be pulled in from that PR.