Skip to content

Conversation

@HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Nov 5, 2025

Reduce disk on multipath via qmp, then reboot.
{ "execute": "device_del", "arguments": { "id": "/machine/peripheral-anon/device[3]"}}

See https://issues.redhat.com/browse/OCPBUGS-56597

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test case, multipath.single-disk, to verify that a multipath device can be correctly reduced to a single path after one of its underlying block devices is removed. The changes include a new test function, modifications to the QEMU platform code to allow for block device removal, and associated test setup. My review focuses on the robustness of the new test logic and code style consistency. I've identified a potential bug in parsing command output within the test and a style inconsistency in one of the new functions.

@HuijingHei HuijingHei requested a review from ravanelli November 5, 2025 09:10
@HuijingHei HuijingHei force-pushed the multipath-one-disk branch 4 times, most recently from fe98f73 to 19f372f Compare November 5, 2025 09:52
@HuijingHei HuijingHei changed the title tests: add multipath.single-disk to verify that multipath can be tests: add multipath.single-disk to verify that multipath can be reduced to one path Nov 5, 2025
@HuijingHei HuijingHei force-pushed the multipath-one-disk branch 4 times, most recently from 1502c7e to 29aadf7 Compare November 10, 2025 02:02
@HuijingHei
Copy link
Member Author

Confirm with @ravanelli , the failed CI ci/prow/rhcos is blocked by https://issues.redhat.com/browse/RHEL-126696

=== RUN   multipath.single-disk
--- FAIL: multipath.single-disk (667.10s)
        multipath.go:273: Failed to reboot the machine: machine "b56daba4-bd95-4bfb-a151-964c2619c032" failed to start: ssh journalctl failed: time limit exceeded

reduced to one path

Reduce disk on multipath via qmp, then reboot.
`{ "execute": "device_del", "arguments": { "id": "/machine/peripheral-anon/device[3]"}}`

See https://issues.redhat.com/browse/OCPBUGS-56597
@HuijingHei
Copy link
Member Author

@ravanelli could you help to review this, as the new coreos-installer is synced to 4.19 plashet now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant