Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secex: guard GPG encryption of Ignition config with mutex #3924

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Nov 4, 2024

Running secex tests with --parallel=auto complains:

$ cosa kola run  --qemu-secex --tag secex --qemu-secex-hostkey hostkey.crt --parallel=auto
=== RUN   ext.config.shared.secex.ensure
=== RUN   ext.config.shared.secex.reboot
2024-11-01T17:28:29Z kola: retryloop: failed to bring up machines: encrypting /var/tmp/mantle-qemu2551463228/ignition_crypted.1734631171: exit status 2

Use mutex for gpg --encrypt to avoid this issue.

Running secex tests with `--parallel=auto` complains:
```
$ cosa kola run  --qemu-secex --tag secex --qemu-secex-hostkey hostkey.crt --parallel=auto
=== RUN   ext.config.shared.secex.ensure
=== RUN   ext.config.shared.secex.reboot
2024-11-01T17:28:29Z kola: retryloop: failed to bring up machines: encrypting /var/tmp/mantle-qemu2551463228/ignition_crypted.1734631171: exit status 2
```

Use mutex for `gpg --encrypt` to avoid this issue.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-dubrovskii nikita-dubrovskii merged commit 6813e3f into coreos:main Nov 4, 2024
5 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the gpg_issue branch November 4, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants