Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmdeps: add python3-dnf for now #3910

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

dustymabe
Copy link
Member

OSBuild dropped dnf as a dependency upstream [1] but osbuild-mpp still uses python3-dnf. Let's add the dep here until it's added as a dep on osbuild-tools upstream [2].

[1] osbuild/osbuild#1896
[2] osbuild/osbuild#1908

OSBuild dropped dnf as a dependency upstream [1] but osbuild-mpp
still uses python3-dnf. Let's add the dep here until it's added as
a dep on osbuild-tools upstream [2].

[1] osbuild/osbuild#1896
[2] osbuild/osbuild#1908
@dustymabe dustymabe enabled auto-merge (rebase) October 21, 2024 18:53
Copy link
Member

@ravanelli ravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-nguyen
Copy link
Member

/test images

@dustymabe
Copy link
Member Author

/retest ci/prow/images

Copy link

openshift-ci bot commented Oct 21, 2024

@dustymabe: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test rhcos

Use /test all to run all jobs.

In response to this:

/retest ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe
Copy link
Member Author

/test images

Copy link

openshift-ci bot commented Oct 21, 2024

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 3f0a1aa link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe dustymabe merged commit 4155975 into coreos:main Oct 21, 2024
4 of 5 checks passed
@dustymabe dustymabe deleted the dusty-vmdeps branch October 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants