Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.15] aliyun: make image replication idempotent #3877

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3875

/assign mike-nguyen

/cherrypick rhcos-4.14 rhcos-4.13 rhcos-4.12

There is a history of failure copying images to other regions on
aliyun. Upstream code that calls the CopyImage code more than once
will get a DuplicateImage error when an image with the same name
already exists. Let's check to see if the image name exists in the
region before attempting to copy the image to the region and return
early if it already exists.
Copy link

openshift-ci bot commented Sep 13, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe dustymabe merged commit 16f2fb6 into coreos:rhcos-4.15 Sep 13, 2024
3 checks passed
@mike-nguyen
Copy link
Member

/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

@openshift-cherrypick-robot
Copy link
Author

@mike-nguyen: new pull request created: #3879

In response to this:

/cherrypick rhcos-4.14
/cherrypick rhcos-4.13
/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mike-nguyen
Copy link
Member

/cherrypick rhcos-4.13

@openshift-cherrypick-robot
Copy link
Author

@mike-nguyen: new pull request created: #3880

In response to this:

/cherrypick rhcos-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mike-nguyen
Copy link
Member

/cherrypick rhcos-4.12

@openshift-cherrypick-robot
Copy link
Author

@mike-nguyen: new pull request created: #3881

In response to this:

/cherrypick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants