add kola test for stable-root-symlink #2517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: coreos/fedora-coreos-tracker#759 Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
|
Let's make it an external test instead as part of coreos/fedora-coreos-config#1308? See example tests in |
bgilbert
reviewed
Nov 4, 2021
| if err != nil { | ||
| return fmt.Errorf("journalctl: %s", err) | ||
| } | ||
| if !strings.Contains(string(out), link) { |
There was a problem hiding this comment.
It'd be better to write an Ignition config that uses the symlink to modify the partition table, perhaps just by resizing the root partition. That would confirm not only that we created the symlink, but that we did it before ignition-disks ran, and that Ignition was able to use it successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: coreos/fedora-coreos-tracker#759
F-C-C: coreos/fedora-coreos-config#1308