Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

Conversation

@dghubble
Copy link
Member

@dghubble dghubble commented Oct 23, 2017

On call errors, the err from the Hello was returned instead of the call.Err reason for the call failure.

Copy link
Contributor

@sdemos sdemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. +1 on removing the named returns.

@sdemos
Copy link
Contributor

sdemos commented Oct 24, 2017

actually, is there any reason why you didn't also remove the named returns on the New function? it looks like they are defined there but the behavior is ignored and everything is just directly returning instead.

@dghubble
Copy link
Member Author

Yeah, we could drop the named returns.

c := new(Client)
var err error

@dghubble dghubble merged commit 74e03bb into coreos:master Oct 24, 2017
@dghubble dghubble deleted the error-fix branch October 24, 2017 23:38
@dghubble dghubble mentioned this pull request Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants