Skip to content

bootupd: make new packagesystem, using a file, no rpm -q#1121

Open
krolmiki2011 wants to merge 10 commits into
coreos:mainfrom
ImmutableLinux:new-packagesystem
Open

bootupd: make new packagesystem, using a file, no rpm -q#1121
krolmiki2011 wants to merge 10 commits into
coreos:mainfrom
ImmutableLinux:new-packagesystem

Conversation

@krolmiki2011

Copy link
Copy Markdown

Make new packagesystem

We need to make new packagesystem, to make compatiable with other distros

Now we need a manifest file in /usr/share/bootupd/manifest, and its look, like this

'''
grub2-1:2.12-28.fc42,1710000000 shim-15.8-3,1700000000
'''

the new code detecting names: grub*, shim*, and make single names just grub and shim

the idea came from this discussion: #468

Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
@openshift-ci

openshift-ci Bot commented Jun 27, 2026

Copy link
Copy Markdown

Hi @krolmiki2011. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the package system to read package metadata from a manifest file instead of querying the RPM database directly, introducing package name normalization for cross-distro compatibility and moving the legacy RPM-querying logic to a new file. The reviewer feedback highlights a critical inconsistency between the manual Ord implementation and the derived PartialEq/Eq for Module, an inefficiency in finding the maximum timestamp using BTreeSet instead of .max(), and a fragile Unix timestamp parsing approach.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/packagesystem.rs
Comment thread src/packagesystem.rs
Comment thread src/packagesystem.rs
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Signed-off-by: krolmiki2011 <mikolajziolkowski504@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant