health integration

[michaelthatsit]

this is pretty early. all it does is pull the health data from the watch, and push the averages to it.

I'm thinking it's probably best to add this and do any UI changes in a separate PR: In it I would probably add:

TODOs:

• set averages on watch
• sync multiple watches

[CLAassistant]

All committers have signed the CLA.

[Odel]

Would this handle a user switching between two watches throughout the day?

[michaelthatsit]

Not yet no, and some of the discussion on discord suggests some of my initial assumptions were incorrect on how the data storage works on the watch.

This solution works but some steps I'm taking are unnecessary and could impact battery life.

[MrXANA91]

It might be relevant to have the Unit Distance (Miles/Kilometers) setting in the health integration of the mobileapp, if it is not already the case in this PR

[michaelthatsit]

May have gone a bit overboard here. But here's the daily, weekly, and monthly screens for health data. Monthly needs work and as of now you can only view the current day, week, or month.

Monthly is meant to show an area graph of each week of the current month but I'm still playing with KoalaPlot.

[michaelthatsit]

I recognize I might be going overboard with this one so lemme know if you folks want me to scale it back at all @sjp4

[michaelthatsit]

It might be relevant to have the Unit Distance (Miles/Kilometers) setting in the health integration of the mobileapp, if it is not already the case in this PR

I added this in the health settings panel but it doesn't seem to immediately update on the watch.

[michaelthatsit]

I've added metrics to the graphs.

Not the best example. Had to clear local db after merging in the upstream so there's no data for sleep and not a lot for steps.

[sjp4]

@sjp4 I'm still working on the HealthKit and Health Connect integrations but hitting some snags. I'm flagging this as ready for review tho.

I think we can disable the health screen tab, merge this in, then I can tackle an updated device screen and move notification if you want to make more room for the index and health tabs.

Great! Can you split out the UI vs non-UI parts into separate PRs? This one is pretty huge to review in one go

[michaelthatsit]

@sjp4 I've got some time today so I can take a crack at it.

Mind if I leave some UI in the debug settings?

[sjp4]

@sjp4 I've got some time today so I can take a crack at it.

Mind if I leave some UI in the debug settings?

That's fine - thanks!

[michaelthatsit]

@sjp4 Finished the separation of UI and did a little clean up. This PR now only contains watch syncing logic.

I've tested it and everything works as expected, it's now ready for your review.

[sjp4]

First pass - didn't go into detail on all the parsing code etc yet. A few specific comments, for generally it would be great if you could fix the formatting changes (unod changes for existing code, use 4-space indentation instead of 8 for new code); makes it kinda hard to read the changes 😬

[michaelthatsit]

Ah I did a local review using Gemini which for some reason tweaks the formatting at random. I'll go through and lint it.

[michaelthatsit]

@sjp4 went through and fixed the formatting and invocations. Also caught a bug along the way.

Ready for your re-review.