Add library for working with schemas in postgres#9
Merged
hundt-corbalt merged 2 commits intomainfrom Sep 18, 2025
Merged
Conversation
jonah-corbalt
approved these changes
Sep 18, 2025
jonah-corbalt
left a comment
jonah-corbalt
left a comment
There was a problem hiding this comment.
Looks great, a couple potential tweaks.
pgutils/pgutils.go
Outdated
| // Given a postgres connection string, generate a new one with the search path | ||
| // (https://www.postgresql.org/docs/17/ddl-schemas.html#DDL-SCHEMAS-PATH) | ||
| // set to just the given schema name. | ||
| func GetConnectionStringWithSearchPath(connStr, schemaName string) (string, error) { |
There was a problem hiding this comment.
Does this need to be exported? I think it is only used by the functions below.
pgutils/pgutils.go
Outdated
| // (https://www.postgresql.org/docs/17/ddl-schemas.html#DDL-SCHEMAS-PATH) | ||
| // It also registers a cleanup function (https://pkg.go.dev/testing#T.Cleanup) | ||
| // that will drop the schema after the test completes. | ||
| func ReconnectWithSchemaForTest(dbConnectionString string, t *testing.T) *sqlx.DB { |
There was a problem hiding this comment.
This looks great. I think the name would make more sense as ConnectWithSchemaForTest because although callers will often be reconnecting, the function doesn't necessarily do that.
hundt-corbalt
force-pushed
the
hundt-testdb
branch
from
6462981 to
7aec464
Compare
jonah-corbalt
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: used library successfully in https://github.com/Enterprise-CMCS/mac-fc-dso-metrics/pull/155
PR Checklist
Examples:
To provide feedback on this template, visit https://docs.google.com/document/d/1YfTv7Amyop5G_8w1c2GJ_Mu-70L0KkZHhm9f9umDi3U/edit