Avoids buffering bodies when not accessible. Partial fix for Response body buffer #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RequestBodyAccessible
andResponseBodyAccessible
.Note: currently checking for
RequestBodyAccessible
is not effective because we rely onWithRequestBodyAccess()
and it enforces request body access. Opening soon an issue/PR Coraza side.Note: Because of the above mentioned point, one added test is currently commented.
GetHttpResponseBody
) when we reachendOfStream
.Note: I added the LogDebug related to body sizes because I'm experiencing inconsistent behaviors with
OnHttpResponseBody
called more than the expected (bodySize>0
but aftwards no extra body is appended to the HttpResponseBody buffer). This behaviour has to be addressed in order to overcome the double-buffering logic and buffer only Coraza side (therefore reading every time new body frame comes and sending it to Coraza)