[CORL-2882] Fix flaky and slow CommentContainer tests #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a simple stream with one comment so that the test renderer can initiate faster and avoid stalling out on GitHub CI. Based on my experiments, this makes the test pass and also speeds it up by a factor of more than 10x.
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
marcushaddon
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the stream structure for the
render username and bodytest inCommentContainer.spec.tsxthat was timing out and acting flaky.Because the default story fixture provided to the
createTestRendererwas quite large, it was taking a long time to render the DOM inside Jest (more than 1 minute locally).Since we have large stream logic tests elsewhere already, I made a simple story that only has one comment for this specific test which now renders in less than 5 seconds locally.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?No new indices.
How do I test this PR?
Check CI or run
npm run testand see that it passes.Where any tests migrated to React Testing Library?
No
How do we deploy this PR?
No special considerations.