[CORL-2875]: update Redis cache key name for comment embed jsonp #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
|
I'm seeing the redis entry show up when loading the comment in the stream, but not when loading |
marcushaddon
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fix ensures that when the comment embed jsonp is set in the Redis cache, each comment has its own consistent key specific to comment embeds. The comment count jsonp should still have a consistent Redis cache key specific to comment counts, as well.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can go to
/commentEmbed.htmland add a comment embed. Load the page. Go into Redis (docker exec -it redis redis-cli). Check its keys (KEYS *). See that there is a key that corresponds to the comment embed you loaded (something likermc:CoralCommentEmbed&commentID=COMMENT_ID).Also load comment counts somewhere (you can add
<span class="coral-count" data-coral-url="STORY_URL"></span>to your embed index.html` or use multi-site test). Check the keys again and see that there's a key that corresponds to the count as well.Where any tests migrated to React Testing Library?
no
How do we deploy this PR?