Merged
Conversation
…d refined a few translations.
…d more frequently, but it isn’t.
… Chose “biografie” for now.
… acceptable, but “Wachtend op moderatie” sounds more like the correct status message.
…t capital C. Chose to go for the version without capital C, since it’s not a title.
…ccount’. Also, simplified ‘Diens inhoud’ to ‘de inhoud van je gebruikersnaam’.
…ions Feature/mdn 10616 translation additions
Contributor
|
Thanks for your contribution! This is amazing! We are taking a look at it 🎉 |
wyattjoh
previously approved these changes
Jan 16, 2018
Contributor
|
Is it possible for you to re-run linting on your branch @TBeijen? We recently updated to prettier, and need to get this merged with linting finished :) Just run: and commit + push the result. |
Author
|
Merged upstream master and ran Tip for future translators: koimo works nice in identifying deprecated and missing translation keys. |
kgardnr
approved these changes
Jan 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Translated all text fragments into Dutch.
How do I test this PR?
Find someone who speaks Dutch, configure and run.
Kidding aside, I think it will be implicitly tested by us (and perhaps others) moving forward and start deploying talk configured using the Dutch language. Then small details that need tweaking will show themselves.
We did reviews within the team and tried to have labeling of things as consistent as possible.
No brand-specific labels are in this translation, so every Dutch site should be able to use it.
I would expect minor updates later on, as we haven't seen all label in use yet. (Things like text being too long for the space available.)