Pod attach #325
Open
Pod attach #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
reviewed
Mar 4, 2022
| import zio.stream.UStream | ||
|
|
||
| case class AttachedProcessState( | ||
| stdin: Option[Queue[Chunk[Byte]]], |
There was a problem hiding this comment.
Maybe it would be nicer (at least more symmetric :) if this is a sink?
There was a problem hiding this comment.
Yep, it looks better :)
vigoo
reviewed
Mar 4, 2022
| new String(Base64.getEncoder.encode(arr)) | ||
| } | ||
| .mapError(toK8sError) | ||
| stdin <- ZIO.effect(customParameters.get("stdin").exists(_.toBoolean)).mapError(toK8sError) |
There was a problem hiding this comment.
I did not check the schema, just some thoughts:
- If all the
connectoperations havestdin,stdoutandstderrthen these could be fix built-in parameters, like for example the delete parameters and the watch filters. - If it is not available for all, is the
AttachedProcessStatea good result type for those operations?
There was a problem hiding this comment.
- They don't, port forward only has a list of ports, and there are port, service and pod proxy endpoints that have action connect, they have just path as option
- No, it only makes sense for attach and exec
|
looks very good, added two questions |
use sink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command=ls&command=-allbut generated code accepts only one command{ "description": "Command is the remote command to execute. argv array. Not executed within a shell.", "in": "query", "name": "command", "type": "string", "uniqueItems": true }"x-kubernetes-action": "connect"other actions like port forward, service proxy contain even more, how should we filter or group them?