forked from open-telemetry/opentelemetry-python-contrib
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(async-io): check for __name__ atribute when tracing coroutine
- Loading branch information
Showing
3 changed files
with
64 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
instrumentation/opentelemetry-instrumentation-asyncio/tests/test_asyncio_anext.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
import asyncio | ||
import sys | ||
from unittest.mock import patch | ||
|
||
# pylint: disable=no-name-in-module | ||
from opentelemetry.instrumentation.asyncio import AsyncioInstrumentor | ||
from opentelemetry.instrumentation.asyncio.environment_variables import ( | ||
OTEL_PYTHON_ASYNCIO_COROUTINE_NAMES_TO_TRACE, | ||
) | ||
from opentelemetry.test.test_base import TestBase | ||
from opentelemetry.trace import get_tracer | ||
|
||
from .common_test_func import async_func | ||
|
||
|
||
class TestAsyncioAnext(TestBase): | ||
@patch.dict( | ||
"os.environ", | ||
{OTEL_PYTHON_ASYNCIO_COROUTINE_NAMES_TO_TRACE: "async_func"}, | ||
) | ||
def setUp(self): | ||
super().setUp() | ||
AsyncioInstrumentor().instrument() | ||
self._tracer = get_tracer( | ||
__name__, | ||
) | ||
|
||
def tearDown(self): | ||
super().tearDown() | ||
AsyncioInstrumentor().uninstrument() | ||
|
||
# Asyncio anext() does not have __name__ attribute, which is used to determine if the coroutine should be traced. | ||
# This test is to ensure that the instrumentation does not break when the coroutine does not have __name__ attribute. | ||
def test_asyncio_anext(self): | ||
async def main(): | ||
async def async_gen(): | ||
for i in range(2): | ||
yield i | ||
|
||
async_gen_instance = async_gen() | ||
a = anext(async_gen_instance) | ||
await asyncio.create_task(a) | ||
|
||
asyncio.run(main()) | ||
spans = self.memory_exporter.get_finished_spans() | ||
self.assertEqual(len(spans), 0) |