Ensure that the batch processor is always last in the pipeline #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
requested review from
povilasv,
oded-dd and
nicolastakashi
as code owners
povilasv
approved these changes
Mar 5, 2024
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
force-pushed
the
batch-processor-order
branch
from
c206701
to
abb8a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://coralogix.atlassian.net/browse/ES-53
Due to the best practice and in order to avoid potential interference in batching from other processors, this change ensures batch processor is always the last one in the pipeline. This means that regardless of users input, presets and other config manipulation, we won't have to worry about wrong order of the batch processor.