Use image from values YAML for the MySQL sidecar #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
requested review from
povilasv,
oded-dd and
nicolastakashi
as code owners
nicolastakashi
approved these changes
Aug 11, 2023
povilasv
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Use image from values config Signed-off-by: Matej Gera <matejgera@gmail.com> * Bump chart and regenerate examples Signed-off-by: Matej Gera <matejgera@gmail.com> --------- Signed-off-by: Matej Gera <matejgera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, we do not provide the
imageto the MySQL sidecar connector, which ends up using the latest core collector by default. However, this is incorrect since the core collector does not include thefilelogreceiver and it makes it not possible to configure image version etc.With this change the sidecar will share the same image as the other collectors.