[FIX] missing config key ta static config #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oded-dd
approved these changes
Oct 8, 2024
nicolastakashi
force-pushed
the
fix/target-allocator-scrape-config
branch
3 times, most recently
from
1ed4b59
to
3b2da9a
Compare
nicolastakashi
force-pushed
the
fix/target-allocator-scrape-config
branch
from
3b2da9a
to
181fb8d
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
charts/opentelemetry-collector/templates/configmap-targetallocator.yamlfile. The change modifies the structure of thescrape_configsconfiguration to nest it under a newconfigkey.charts/opentelemetry-collector/templates/configmap-targetallocator.yaml: Nestedscrape_configsunder a newconfigkey.As we can see on the code available here, this key was missing on the initial configuration.