Skip to content

Ignore writer shutdown error #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Ignore writer shutdown error #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ba8cf
ignore writer shutdown error
fsdvh Sep 25, 2024
d139af5
cargo check
fsdvh Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions datafusion/core/src/datasource/file_format/write/orchestration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,12 @@ pub(crate) async fn stateless_serialize_and_write_files(

// Finalize or abort writers as appropriate
for mut writer in finished_writers.into_iter() {
writer.shutdown()
.await
.map_err(|_| internal_datafusion_err!("Error encountered while finalizing writes! Partial results may have been written to ObjectStore!"))?;
if let Err(e) = writer.shutdown().await {
// ignore if writer already closed
if e.kind() != std::io::ErrorKind::InvalidInput {
Copy link
Collaborator

@thinkharderdev thinkharderdev Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a warning here as well.

If this is a quick fix we need for now then it's fine but I don't think we can upstream this as it's not valid in all cases.

return Err(internal_datafusion_err!("Error encountered while finalizing writes! Partial results may have been written to ObjectStore! Error: {e}"));
}
}
}

if any_errors {
Expand Down