Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon for recent activity #2122

Open
trucy opened this issue Jan 17, 2023 · 17 comments
Open

Update icon for recent activity #2122

trucy opened this issue Jan 17, 2023 · 17 comments
Assignees
Labels
good first issue Good for newcomers polish

Comments

@trucy
Copy link

trucy commented Jan 17, 2023

Replace where we use the recent activity icon to the one attached in this ticket 🙏

  • nav
  • empty state
  • anywhere else you can find

current:
Screenshot 2023-01-16 at 3 59 05 PM

new:
Screenshot 2023-01-16 at 3 59 02 PM

svg:
format_list_bulleted_FILL0_wght500_GRAD0_opsz24

@trucy trucy added good first issue Good for newcomers polish labels Jan 17, 2023
@nachiketkanore
Copy link

I would like to take this

@trucy
Copy link
Author

trucy commented Jan 23, 2023

@nachiketkanore go for it!

@simplysabir
Copy link

hey, i would like to work on this issue. should i?

@hkirat
Copy link
Contributor

hkirat commented Feb 6, 2023

@simplysabir go for it

@simplysabir
Copy link

On it ser 🫡

@simplysabir
Copy link

@hkirat also can i get the icons download link? Or should i search them on the internet?

@hkirat
Copy link
Contributor

hkirat commented Feb 6, 2023

Hey @simplysabir , the svg to be changed is present in the comment here - #2122 (comment)

@simplysabir
Copy link

@hkirat for setting up this locally, should i follow the README.md video or Some Other? README.md Video seems unclear to me that's why bringing it up

@simplysabir
Copy link

also sir currently i use npm and backpack uses yarn. so, if i installed yarn then there will be any problem? coz both npm and yarn will be installed

@simplysabir
Copy link

Hey @hkirat ,
i haven't setup the project locally yet but was going through the code and i can only find it in the navbar. correct me if i'm wrong
image

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2023

@simplysabir try digging deeper, it might not be called nav

@simplysabir
Copy link

is it in these files? i tried my best to find lemme know if i'm correct or not
image

@hkirat
Copy link
Contributor

hkirat commented Feb 9, 2023

@simplysabir try setting up the project locally and start commenting out components from the top level Router.
That should lead you to the Tabs component you're looking for

@simplysabir
Copy link

yeah on it.

@simplysabir
Copy link

@hkirat getting problem in setting up locally

@simplysabir
Copy link

while running yarn build i'm getting this

error_backpack

@Anmol567
Copy link
Contributor

Hey was able to make the changes kindly have a look at the PR #3489.

Anmol567 pushed a commit to Anmol567/backpack that referenced this issue Mar 31, 2023
callensm pushed a commit that referenced this issue Mar 31, 2023
Co-authored-by: Anmol Agarwal <anmol@Anmols-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers polish
Projects
None yet
Development

No branches or pull requests

5 participants