more blockchain code isolation

packages/common/src/blockchains/index.ts

@@ -13,6 +13,8 @@ export const BLOCKCHAIN_COMMON: Record<
   {
     PreferencesDefault: SolanaData | EclipseData | EthereumData;
     validatePublicKey: (address: string) => boolean;
+    logoUri: string;
+    bip44CoinType: number;
   }
 > = {
   [Blockchain.ETHEREUM]: {
@@ -29,6 +31,9 @@ export const BLOCKCHAIN_COMMON: Record<
       }
       return true;
     },
+    logoUri:
+      "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/ethereum.png",
+    bip44CoinType: 60,
   },
   [Blockchain.SOLANA]: {
     PreferencesDefault: {
@@ -44,6 +49,9 @@ export const BLOCKCHAIN_COMMON: Record<
       }
       return true;
     },
+    logoUri:
+      "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/solana.png",
+    bip44CoinType: 504,
   },
   [Blockchain.ECLIPSE]: {
     PreferencesDefault: {
@@ -59,5 +67,9 @@ export const BLOCKCHAIN_COMMON: Record<
       }
       return true;
     },
+    // todo
+    logoUri:
+      "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/solana.png",
+    bip44CoinType: 504,
   },
 };

packages/common/src/crypto.ts

@@ -1,19 +1,13 @@
 import BIPPath from "bip32-path";
 
+import { BLOCKCHAIN_COMMON } from "./blockchains";
 import { LOAD_PUBLIC_KEY_AMOUNT } from "./constants";
 import { Blockchain } from "./types";
 
 export const HARDENING = 0x80000000;
 
-// TODO could use SLIP44
-export const blockchainCoinType = {
-  [Blockchain.ETHEREUM]: 60,
-  [Blockchain.SOLANA]: 501,
-  [Blockchain.ECLIPSE]: 501,
-};
-
 export const getCoinType = (blockchain: Blockchain) => {
-  const coinType = blockchainCoinType[blockchain];
+  const coinType = BLOCKCHAIN_COMMON[blockchain].bip44CoinType;
   if (!coinType) {
     throw new Error("Invalid blockchain");
   }

packages/tamagui-core/src/components/BlockchainLogo.tsx

@@ -1,28 +1,9 @@
 import { Image } from "react-native";
-import { Blockchain } from "@coral-xyz/common";
-
-// YES YOU'RE RIGHT THESE ARE HERE AND NOT SOMEWHERE ELSE!
-// until we know the app-extension can handle relative import image paths or w/e, this stays in here on this url
-const Images = {
-  ethereumLogo:
-    "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/ethereum.png",
-  solanaLogo:
-    "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/solana.png",
-  eclipseLogo:
-    "https://s3.us-east-1.amazonaws.com/app-assets.xnfts.dev/images/useBlockchainLogo/solana.png", // todo
-};
+import type { Blockchain} from "@coral-xyz/common";
+import { BLOCKCHAIN_COMMON } from "@coral-xyz/common";
 
 function getBlockchainLogo(blockchain: Blockchain) {
-  switch (blockchain) {
-    case Blockchain.ETHEREUM:
-      return Images.ethereumLogo;
-    case Blockchain.SOLANA:
-      return Images.solanaLogo;
-    case Blockchain.ECLIPSE:
-      return Images.eclipseLogo;
-    default:
-      return Images.solanaLogo;
-  }
+  return BLOCKCHAIN_COMMON[blockchain].logoUri;
 }
 
 export function BlockchainLogo({