Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache fsspec downloaded files #2132

Merged
merged 12 commits into from
Nov 9, 2022
Merged

Cache fsspec downloaded files #2132

merged 12 commits into from
Nov 9, 2022

Conversation

erogol
Copy link
Member

@erogol erogol commented Nov 8, 2022

fsspec will cache downloaded files automatically to the tts cache path

@erogol erogol requested a review from WeberJulian November 8, 2022 10:51
@WeberJulian
Copy link
Contributor

Looks good to me, but this won't actually change the behaviour of say this file

self.encoder_criterion = self.encoder.load_checkpoint(
as long as we don't enable it by default or where it would be usefull right?

@erogol
Copy link
Member Author

erogol commented Nov 8, 2022

@WeberJulian yeah I think cache should be explicitly set true for all calls of load_checkpoint if it is what you mean.

@WeberJulian
Copy link
Contributor

@WeberJulian yeah I think cache should be explicitly set true for all calls of load_checkpoint if it is what you mean.

My question is should we enable it by default for managers.py or maybe expose a flag that does it for this script?

@erogol
Copy link
Member Author

erogol commented Nov 9, 2022

I don't think its a good idea. We could be using the same model without knowing it since the model file name is the same.

@erogol erogol merged commit 8cb1433 into dev Nov 9, 2022
@erogol erogol deleted the cache-fsspec branch November 9, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants