Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pyworld by pyin #1946

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Replace pyworld by pyin #1946

merged 2 commits into from
Sep 9, 2022

Conversation

Edresson
Copy link
Contributor

@Edresson Edresson commented Sep 8, 2022 •
edited
Loading

This PR fix the issue #1779

@Edresson Edresson requested a review from erogol September 8, 2022 13:59
@erogol
Copy link
Member

erogol commented Sep 8, 2022

You need to do such changes in the numpy_transforms too. It is failing the CI. Even better if you would use compute_f0 from there.

@Edresson
Copy link
Contributor Author

Edresson commented Sep 8, 2022

You need to do such changes in the numpy_transforms too. It is failing the CI. Even better if you would use compute_f0 from there.

Yeah, I was doing it :)

@erogol
Copy link
Member

erogol commented Sep 9, 2022

Thx @Edresson for the ✨PR✨

@erogol erogol merged commit 371772c into dev Sep 9, 2022
@erogol erogol deleted the dev-pyin branch September 9, 2022 08:43
@Edresson Edresson mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erogol erogol Awaiting requested review from erogol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Edresson @erogol