Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dune >= 3.15.3 in all packages restricting dune to < 3.14 #3090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MSoegtropIMC
Copy link
Contributor

No description provided.

@silene
Copy link
Contributor

silene commented Jul 4, 2024

Unfortunately, Dune >= 3.14 (which includes 3.15.3) is incompatible with the way our continuous integration is setup, as you can see from the failures. (My hypothesis is that dune subst does not support the fact that the home directory contains an opam component.)

Polluting the opam files of coq-core with the upper bound on dune is certainly crude, but it gets the continuous integration running. It would be better to somehow enforce the upper bound in scripts/opam-coq-setup-root, for instance. But nobody investigated how to do that properly.

@SkySkimmer
Copy link
Contributor

Doesn't seem to work

@MSoegtropIMC
Copy link
Contributor Author

The issue is that there are some coq opam packages which do require dune >= 3.14. Also in Coq Platform I had to upgrade to dune 3.15.3 cause of issues.

IMHO it should be discussed with the dune team if the way the CI is setup will permanently be incompatible with dune - in this case the only way is to change the CI setup - or if dune will be made compatible in the near future.

@MSoegtropIMC
Copy link
Contributor Author

For a few months I can use patched opam files in Coq Platform for the coq packages, but not forever.

@SkySkimmer
Copy link
Contributor

cc @rgrinberg

@erikmd
Copy link
Member

erikmd commented Jul 5, 2024

FYI @rgrinberg, the issue at stake would be: ocaml/dune#9895 (comment)

@rgrinberg
Copy link

Not sure I really understand the issue, but you might be able to fix if you disable substitution altogether with (subst disabled) in the dune-project file. To help out more, I will need a ticket with a more complete description of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants