Improve documentation some more #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberplant
reviewed
Dec 8, 2023
copy
reviewed
Dec 9, 2023
docs/archlinux.md
Outdated
|
|
||
| In the future the community might come up with an alternative distribution based on Archlinux to maintain support for x86. At this point in time [archlinux32](https://mirror.archlinux32.org) seems to work. | ||
| In the future, the community might come up with an alternative distribution based on Arch Linux to maintain support for the 32-bit architecture. At this point in time [archlinux32](https://mirror.archlinux32.org) seems to work. |
There was a problem hiding this comment.
It'd probably better to delete the first paragraph, and refer to archlinux32 directly.
docs/filesystem.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| A 9p filesystem is supported by the emulator, using a virtio transport. Using | |||
| A 9p file system is supported by v86, using a virtio transport. Using | |||
There was a problem hiding this comment.
"filesystem" is correct (see https://en.wikipedia.org/wiki/File_system), and more consistent with the rest of the docs.
Co-authored-by: Fabian <copy@copy.sh>
|
Thanks! |
russor
pushed a commit
to russor/v86
that referenced
this pull request
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this helps a bit :)